struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukaszlen...@apache.org>
Subject Re: beta3 testing
Date Thu, 11 Feb 2016 07:23:12 GMT
2016-02-08 13:50 GMT+01:00 Lukasz Lenart <lukaszlenart@apache.org>:
> 2016-02-08 13:44 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
>> I was dong some more testing and noticed that my message store interceptor
>> messages have stopped working.
>>
>> There is a check in the
>> org.apache.struts2.interceptor.MessageStoreInterceptor to see if the
>> response has been committed, and if it is skip the messages processing.
>>
>> boolean isCommitted = ServletActionContext.getResponse().isCommitted();
>>
>> LOG.debug("Response was already committed, cannot store messages!");
>>
>> I do not think I am committing any struts stuff so was wondering if
>> anything has changed that would?
>
> Yes, it's a side effect of this change [1] but I already refactored
> the code [2] and now it works even with redirects - is it worth to
> backport it to 2.3.25?
>
> [1] https://issues.apache.org/jira/browse/WW-4600
> [2] https://issues.apache.org/jira/browse/WW-4605

I have ported the same solution to 2.3.25, I hope it won't break anything :)


Regards
-- 
Ɓukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message