struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Gainty <mgai...@hotmail.com>
Subject RE: SMI on steroids Feature Request
Date Fri, 12 Feb 2016 13:45:52 GMT
Hi Greg
since barosso got a FT job at Amazon the Struts managers that call the shots on new Struts
features are Lukasz and Dave

If they say this is a good idea that should be voted on and then implemented then perhaps
our feature might be implemented

My suggestions is to lay out the groundwork for the new feature that is:
Make the case that users like yourself would find this new feature useful
If possible submit a working patch to latest codebase and a testcase demonstrating the viability
of this new feature
As you probably have guessed already i am not a manager..so this is not my call
Good Luck Greg!
Martin 
______________________________________________ 
                                                                                         
        


> Date: Thu, 11 Feb 2016 11:02:41 +0000
> Subject: Re: SMI on steroids
> From: gregh3269@gmail.com
> To: dev@struts.apache.org
> 
> Can there be two levels on the SMI?
> 
> If DMI is on and SMI is in relaxed-strict mode (false) we can leave the
> 
> {1} and prefix{0}suffix in so it works.
> 
> although it would be better to have some kind of regex ie
> regex:([A-Z-a-z]*) for safety plus a max length!
> 
> Then if SMI is in strict mode (true) remove {1} and prefix{0}suffix so it
> will then fall back on the global/allowed-methods.
> 
> Just a thought.
> 
> Cheers Greg
> 
> 
> 
> 
> On 5 February 2016 at 09:23, Lukasz Lenart <lukaszlenart@apache.org> wrote:
> 
> > 2016-02-05 10:20 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
> > > my lastest comment..
> > >
> > > The entry that we don't want is {1} style
> > >
> > > PatternAllowedMethod{allowedMethodPattern=(.*), original='\{1\}'\}
> > >
> > > which is don't check anything, effectively disabling SMI.
> > >
> > > run{1}This style could be left in, as they are pretty restrictive, or is
> > > there a regex for the pattern that could be added to the globals,
> > > acknowledging there is a potential risk in your DMI?
> >
> > Yes, that true, but this approach is very strict and can affect many
> > users/projects. I would like to hear other's opinion
> >
> >
> > Regards
> > --
> > Ɓukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
 		 	   		  
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message