Mailing-List: contact dev-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <dev@struts.apache.org>
From: lukaszlenart <git@git.apache.org>
To: dev@struts.apache.org
Reply-To: dev@struts.apache.org
References: <git-pr-85-struts@git.apache.org>
In-Reply-To: <git-pr-85-struts@git.apache.org>
Subject: [GitHub] struts pull request: WW-4594: Configure TilesDefs by
 annotating Ac...
Content-Type: text/plain
Message-Id: <20160129165342.7C743E03BE@git1-us-west.apache.org>
Date: Fri, 29 Jan 2016 16:53:42 +0000 (UTC)

Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/85#discussion_r51284673
  
    --- Diff: apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java ---
    @@ -0,0 +1,21 @@
    +package org.apache.struts2.showcase.tiles;
    +
    +import org.apache.struts2.convention.annotation.Namespace;
    +import org.apache.struts2.convention.annotation.ParentPackage;
    +import org.apache.struts2.convention.annotation.Result;
    +import org.apache.struts2.tiles.annotation.TilesDefinition;
    +import org.apache.struts2.tiles.annotation.TilesPutAttribute;
    +
    +import com.opensymphony.xwork2.ActionSupport;
    +
    +@Namespace("/tiles")
    +@ParentPackage("tiles")
    +@Result(name = "success", type="tiles")
    +@TilesDefinition(extend = "showcase.annotations", putAttributes = {
    +        @TilesPutAttribute(name = "header", value = "/WEB-INF/tiles/header.jsp"),
    +        @TilesPutAttribute(name = "body", value = "/WEB-INF/tiles/body.ftl"), })
    --- End diff --
    
    I think the last comma isn't needed and also what do you think about formatting like this:
    ```java
    @Namespace("/tiles")
    @ParentPackage("tiles")
    @Result(name = "success", type="tiles")
    @TilesDefinition(extend = "showcase.annotations", putAttributes = {
        @TilesPutAttribute(name = "header", value = "/WEB-INF/tiles/header.jsp"),
        @TilesPutAttribute(name = "body", value = "/WEB-INF/tiles/body.ftl")
    })
    ```
    ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org