struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukaszlenart <...@git.apache.org>
Subject [GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...
Date Fri, 29 Jan 2016 16:56:14 GMT
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/85#discussion_r51285002
  
    --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java
---
    @@ -111,6 +133,31 @@ public void doExecute(String location, ActionInvocation invocation)
throws Excep
     
             Request request = new ServletRequest(applicationContext, httpRequest, httpResponse);
     
    +        boolean definitionValid = false;
    +        try {
    +            LOG.debug("checking if tiles definition exists '{}'", location);
    +            definitionValid = container.isValidDefinition(location, request);
    +        } catch (TilesException e) {
    +            LOG.warn("got TilesException while checking if definiton exists, ignoring
it", e);
    +        }
    +        if (!definitionValid) {
    +            if (tilesDefinition == null) {
    +                // tilesDefinition not found yet, search in action
    --- End diff --
    
    The same here, `LOG.trace`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message