struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aleksandr-m <...@git.apache.org>
Subject [GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Date Tue, 19 Jan 2016 07:19:13 GMT
Github user aleksandr-m commented on a diff in the pull request:

    https://github.com/apache/struts/pull/75#discussion_r50079358
  
    --- Diff: core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
    @@ -777,11 +777,21 @@ protected Class verifyResultType(String className, Location loc)
{
                     }
                     params.putAll(resultParams);
     
    -                ResultConfig resultConfig = new ResultConfig.Builder(resultName, resultClass)
    -                        .addParams(params)
    -                        .location(DomHelper.getLocationObject(element))
    -                        .build();
    -                results.put(resultConfig.getName(), resultConfig);
    +                Set<String> resultNamesSet;
    +                if (",".equals(resultName.trim())) {
    +                    resultNamesSet = new HashSet<>(1);
    +                    resultNamesSet.add(resultName);
    --- End diff --
    
    Currently it is allowed to have a result name as a `,`. And `TextParseUtil.commaDelimitedStringToSet`
will produce empty set in that case. Note that it is trimmed so the result name can be something
like "&nbsp;&nbsp;&nbsp;," also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message