Mailing-List: contact dev-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <dev@struts.apache.org>
From: cnenning <git@git.apache.org>
To: dev@struts.apache.org
Reply-To: dev@struts.apache.org
References: <git-pr-59-struts@git.apache.org>
In-Reply-To: <git-pr-59-struts@git.apache.org>
Subject: [GitHub] struts pull request: Upgrade tiles plugin
Content-Type: text/plain
Message-Id: <20151127141647.EB060E0414@git1-us-west.apache.org>
Date: Fri, 27 Nov 2015 14:16:47 +0000 (UTC)

Github user cnenning commented on the pull request:

    https://github.com/apache/struts/pull/59#issuecomment-160148544
  
    As I said on the mailing-list before, I'm not deep into tiles. But from just reading the code it seems reasonable.
    
    I cannot test it with an own app as I switched to tiles3 in the meantime.
    
    When accessing tiles demo in showcase app I got attached exception. The class `javax.el.ELContext` exists in several JARs (like jsp-api.jar or el-api.jar) so it might be a classpath issue. The Exception disapears when I remove the `${title}` expression in `header.jsp`.
    
    I like how dependencies are declared. I.E. that all the tiles jars like `tiles-jsp`, `tiles-freemarker` are explicitly listed. The tiles3-plugin just declares `tiles-extras` which drags in a lot of stuff I don't want in my app.
    [tiles-stacktrace.txt](https://github.com/apache/struts/files/45777/tiles-stacktrace.txt)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org