struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LukaszRacon <...@git.apache.org>
Subject [GitHub] struts pull request: Form.getValidators does not respect validateA...
Date Mon, 09 Nov 2015 23:09:27 GMT
GitHub user LukaszRacon opened a pull request:

    https://github.com/apache/struts/pull/57

    Form.getValidators does not respect validateAnnotatedMethodOnly flag

    WW-4139 removed method name from getValidators call.  While this works
    fine for a case mentioned in that ticket it fails to account for a case
    when
    dynamicMethodCalls and validateAnnotatedMethodOnly are used. Without
    method name actionValidatorManager.getValidators returns all validators
    defined for a given field.
    Expected behavior for dynamicMethodCalls with
    validateAnnotatedMethodOnly case is to return validators for a given
    field defined at the method level.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LukaszRacon/struts form-validators

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit ee562666abf01faf4dd73f65c9f4d77b079423d1
Author: Lukasz Racon <lracon@jgsullivan.com>
Date:   2015-11-09T23:02:02Z

    Form.getValidators does not respect validateAnnotatedMethodOnly flag
    
    WW-4139 removed method name from getValidators call.  While this works
    fine for a case mentioned in that ticket it fails to account for a case
    when
    dynamicMethodCalls and validateAnnotatedMethodOnly are used. Without
    method name actionValidatorManager.getValidators returns all validators
    defined for a given field.
    Expected behavior for dynamicMethodCalls with
    validateAnnotatedMethodOnly case is to return validators for a given
    field defined at the method level.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message