struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken McWilliams <ken.mcwilli...@gmail.com>
Subject Re: Upgrading Tiles plugin
Date Sat, 21 Nov 2015 00:20:08 GMT
Everything sounds great. I do recommend keeping the regex matching. I it's
hard to know which types of view support should be dropped, I think it is
better to err on the side of inclusion.
On another front, don't you like how they select the type of matcher by
using a prefix in the string? "OGNL:" , "regex:", etc., I thought that was
pretty slick., we only allow one matcher... I mean they could have used
another tag attribute to account for that, but putting it in the string
reads better.

On Thu, Nov 19, 2015 at 11:49 PM, Lukasz Lenart <lukaszlenart@apache.org>
wrote:

> 2015-11-20 7:43 GMT+01:00 Christoph Nenning <Christoph.Nenning@lex-com.net
> >:
> > I'm not so deep into tiles to have a strong opinion. But that makes a lot
> > of sense to me. Can this be shared between tiles2 and tiles3 plugins?
>
> Yes, I think after gathering all the knowledge about Tiles I'm gonna
> update the Tiles 3 Plugin as well :)
>
>
> Regards
> --
> Ɓukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message