struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cnenning <...@git.apache.org>
Subject [GitHub] struts pull request: Http parameters
Date Mon, 30 Nov 2015 15:29:22 GMT
Github user cnenning commented on the pull request:

    https://github.com/apache/struts/pull/58#issuecomment-160661450
  
    As far as I see it, there is no new functionality (like security checks) right now. Currently
the code is just refactored to work with new interface/class `Parameter` and `HttpParameters`,
am I right?
    
    The method `Parameter.isExpression()` seems not to be used or implemented (ohter than
`return false`)? The new class `Evaluated` is only used by `AliasInterceptor`?
    
    This looks promising ...
    
    Beside future things, I have two questions about how things are done right now:
    * It seems to me that currently converters are not used. Now we got `Parameter.Request.getValue()`.
Should converters be used there?
    * My first impression is that that method could be slow, as it could be called quite often.
What about caching the result of `toStringArray()` in a member?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message