struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukaszlenart <...@git.apache.org>
Subject [GitHub] struts pull request: WW-4427 - Converters are no longer applied to...
Date Tue, 09 Dec 2014 18:17:14 GMT
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/32#discussion_r21548312
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
    @@ -351,6 +351,8 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException
{
                 value = getValue(expr, asType);
                 if (value == null) {
                     value = findInContext(expr);
    +                final XWorkConverter conv = ((Container)getContext().get(ActionContext.CONTAINER)).getInstance(XWorkConverter.class);
    --- End diff --
    
    Why do you looking for Converter instead of `@Inject` it? You can inject it with
    ```java
        private XWorkConverter conv;
    
        @Inject
        public void setXWorkConverter(XWorkConverter conv) {
            this.conv = conv;
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message