Mailing-List: contact dev-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <dev@struts.apache.org>
From: foogaro <git@git.apache.org>
To: dev@struts.apache.org
Reply-To: dev@struts.apache.org
References: <git-pr-20-struts@git.apache.org>
In-Reply-To: <git-pr-20-struts@git.apache.org>
Subject: [GitHub] struts pull request: Localized by classloader
Content-Type: text/plain
Message-Id: <20140730101704.F0174950C28@tyr.zones.apache.org>
Date: Wed, 30 Jul 2014 10:17:04 +0000 (UTC)

Github user foogaro commented on a diff in the pull request:

    https://github.com/apache/struts/pull/20#discussion_r15575658
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java ---
    @@ -136,13 +129,21 @@ public static void setReloadBundles(boolean reloadBundles) {
          */
         public static void addDefaultResourceBundle(String resourceBundleName) {
             //make sure this doesn't get added more than once
    -        synchronized (DEFAULT_RESOURCE_BUNDLES) {
    -            DEFAULT_RESOURCE_BUNDLES.remove(resourceBundleName);
    -            DEFAULT_RESOURCE_BUNDLES.add(0, resourceBundleName);
    +        ClassLoader ccl = null;
    +        synchronized (classLoaderMap) {
    --- End diff --
    
    What you think if we use the String "XWORK_MESSAGES_BUNDLE" as synchronization for that code block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org