struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foogaro <>
Subject [GitHub] struts pull request: Localized by classloader
Date Wed, 30 Jul 2014 10:33:16 GMT
Github user foogaro commented on a diff in the pull request:
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/
    @@ -136,13 +129,21 @@ public static void setReloadBundles(boolean reloadBundles) {
         public static void addDefaultResourceBundle(String resourceBundleName) {
             //make sure this doesn't get added more than once
    -        synchronized (DEFAULT_RESOURCE_BUNDLES) {
    -            DEFAULT_RESOURCE_BUNDLES.remove(resourceBundleName);
    -            DEFAULT_RESOURCE_BUNDLES.add(0, resourceBundleName);
    +        ClassLoader ccl = null;
    +        synchronized (classLoaderMap) {
    --- End diff --
    No, but we do need synchronization because we don't want any race condition while storing
bundles array into the ```ConcurrentMap```. That's why using the string ```XWORK_MESSAGES_BUNDLE```
might be a good alternative.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message