struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukaszlenart <...@git.apache.org>
Subject [GitHub] struts pull request: Localized by classloader
Date Wed, 30 Jul 2014 10:06:37 GMT
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/20#discussion_r15575275
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/util/LocalizedTextUtil.java
---
    @@ -246,35 +245,32 @@ public static String findDefaultText(String aTextName, Locale locale,
Object[] p
         public static ResourceBundle findResourceBundle(String aBundleName, Locale locale)
{
             String key = createMissesKey(aBundleName, locale);
     
    -        ResourceBundle bundle;
    +        ResourceBundle bundle = null;
     
    +        ClassLoader classLoader = getThreadCurrentThreadGetContextClassLoader();
             try {
    +            key = classLoader.hashCode()+key;
    --- End diff --
    
    Can we inline `createMissesKey` instead duplicated `key`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message