From dev-return-65956-apmail-struts-dev-archive=struts.apache.org@struts.apache.org Tue Jun 10 13:58:08 2014 Return-Path: X-Original-To: apmail-struts-dev-archive@www.apache.org Delivered-To: apmail-struts-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 042151100B for ; Tue, 10 Jun 2014 13:58:08 +0000 (UTC) Received: (qmail 90592 invoked by uid 500); 10 Jun 2014 13:58:07 -0000 Delivered-To: apmail-struts-dev-archive@struts.apache.org Received: (qmail 90531 invoked by uid 500); 10 Jun 2014 13:58:06 -0000 Mailing-List: contact dev-help@struts.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Struts Developers List" Reply-To: "Struts Developers List" Delivered-To: mailing list dev@struts.apache.org Received: (qmail 90514 invoked by uid 99); 10 Jun 2014 13:58:06 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jun 2014 13:58:06 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 4611391D050; Tue, 10 Jun 2014 13:58:06 +0000 (UTC) From: josephw To: dev@struts.apache.org Reply-To: dev@struts.apache.org Message-ID: Subject: [GitHub] struts pull request: Fix a few NullPointerExceptions identified by... Content-Type: text/plain Date: Tue, 10 Jun 2014 13:58:06 +0000 (UTC) GitHub user josephw opened a pull request: https://github.com/apache/struts/pull/15 Fix a few NullPointerExceptions identified by Eclipse Eclipse's static analysis of nulls identifies a number of spots where a `NullPointerException` can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/josephw/struts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 ---- commit 81cdd6e0d8fe01616e5c3055e5536ee63199b6e6 Author: Joseph Walton Date: 2014-06-10T12:21:39Z Clean up potential NullPointerExceptions. - Construct BufferedReaders ahead of try blocks - Don't catch exceptions in tests - Specifically check for mismatched braces in patterns - Fail on an unknown numeric type commit f98e92c154add1c869efe88ce1fdba984a5f71aa Author: Joseph Walton Date: 2014-06-10T12:21:55Z Fix potential NullPointerExceptions. - Allow for a null location when logging - Don't try to use a null LocationFinder ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org For additional commands, e-mail: dev-help@struts.apache.org