struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukaszlenart <...@git.apache.org>
Subject [GitHub] struts pull request: WW-4360: Fix a few NullPointerExceptions iden...
Date Sat, 28 Jun 2014 07:02:18 GMT
Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/16#discussion_r14322940
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
    @@ -425,7 +427,7 @@ protected void addAction(Element actionElement, PackageConfig.Builder
packageCon
             } else {
                 if (!verifyAction(className, name, location)) {
                     if (LOG.isErrorEnabled())
    -                    LOG.error("Unable to verify action [#0] with class [#1], from [#2]",
name, className, location.toString());
    +                    LOG.error("Unable to verify action [#0] with class [#1], from [#2]",
name, className, ObjectUtils.toString(location));
    --- End diff --
    
    I prefer extending `Logger` interface and define new method: `void error(String msg, Object...
args);` the same as I already did for `debug` and `trace`. Thus will allow reduce `ObjectUtils`
dependency and give new functionality :-)
    
    This can be handled with dedicated PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message