struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Pratt <thechrispr...@gmail.com>
Subject Re: Less boilerplate in code
Date Wed, 14 May 2014 17:33:37 GMT
If you want a really powerful version of what they did, check out my onyx
project (https://code.google.com/p/anodyzed/).  It's kind of been
languishing since I haven't found too many people that really care about
logging efficiency, but I'd be totally willing to donate the code to
Struts2 (and do some of the work of integrating it) if it's something you'd
be interested in.
  (*Chris*)


On Wed, May 14, 2014 at 3:51 AM, Lukasz Lenart <lukaszlenart@apache.org>wrote:

> I went through how SLF4J is implemented and they did exactly what I
> want to do :-)
>
> I need some regex Ninja to remove if statement around LOG's calls
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> 2014-05-12 13:17 GMT+02:00 Dave Newton <davelnewton@gmail.com>:
> > I think the issue is only when the params are more than just strings,
> e.g.,
> > "long"-running methods.
> >
> > I'd like to ditch the XW facade, though; I think whenever possible we
> > should strip out XW/S2 functionality when it exists in libraries we
> already
> > use (like those older XW string utils).
> >
> > d.
> >
> >
> > On Sun, May 11, 2014 at 4:13 PM, Johannes Geppert <jogep@apache.org>
> wrote:
> >
> >> I prefer to switch slf4j instead of an own xwork logging facade.
> >>
> >>
> >> Regards
> >>
> >> Johannes
> >>
> >> #################################################
> >> web: http://www.jgeppert.com
> >> twitter: http://twitter.com/jogep
> >>
> >>
> >>
> >> 2014-05-10 9:43 GMT+02:00 Lukasz Lenart <lukaszlenart@apache.org>:
> >>
> >> > Hi,
> >> >
> >> > What do you think about that idea [1]?
> >> >
> >> > Basically instead of doing this:
> >> >
> >> > if (LOG.isDebugEnable()) {
> >> >      LOG.debug("Action name is [#0]', actionName);
> >> > }
> >> >
> >> > it will be possible to do this:
> >> >
> >> > LOG.debug("Action name is [#0]', actionName);
> >> >
> >> > with implementation in eg. JdkLogger like this:
> >> >
> >> > public void debug(String message, String... params) {
> >> >     if(isDebugEnable()) {
> >> >          // perform logging
> >> >     }
> >> > }
> >> >
> >> > wiht assumption that we always use version with params and don't use
> >> > string concatenation
> >> >
> >> > [1] https://issues.apache.org/jira/browse/WW-4344
> >> >
> >> >
> >> > Regards
> >> > --
> >> > Łukasz
> >> > + 48 606 323 122 http://www.lenart.org.pl/
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> > For additional commands, e-mail: dev-help@struts.apache.org
> >> >
> >> >
> >>
> >
> >
> >
> > --
> > e: davelnewton@gmail.com
> > m: 908-380-8699
> > s: davelnewton_skype
> > t: @dave_newton <https://twitter.com/dave_newton>
> > b: Bucky Bits <http://buckybits.blogspot.com/>
> > g: davelnewton <https://github.com/davelnewton>
> > so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message