struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Huber <gregh3...@gmail.com>
Subject Re: LocalizedTextUtil mods
Date Thu, 06 Mar 2014 16:51:20 GMT
Following this http://struts.apache.org/git-for-struts.html

 url https://github.com/apachestruts/struts don't look correct? 404  >>
apache/struts <https://github.com/apachestruts/struts>


On 6 March 2014 13:34, Lukasz Lenart <lukaszlenart@apache.org> wrote:

> 2014-03-06 13:38 GMT+01:00 Greg Huber <gregh3269@gmail.com>:
> > Seeing this mod the other day has reminded me that I do a local change on
> > LocalizedTextUtil to speed up the screens.
> >
> > What I do is to add a check to see if the property comes from the
> > getDefaultMessage(..) method (ie from ApplicationResources.properties)
> and
> > if it does skip all the checking that it does (for every request).  If
> you
> > have a lot of inheritance or <s:text> and do not use properties / class
> > name strategy it makes the rendering a whole lot faster.
> >
> > ie
> >
> > HashSet<String> set = defaultLocationMap.get(locale.toString());
> > if(set != null && set.contains(aTextName)){
> > ...
> > }
> >
> > Would this be acceptable here?
>
> It's easier to discuss over code, prepare a branch then Pull Request
> via GitHub and we can discuss :-)
>
>
> Regards
> --
> Ɓukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message