struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Huber <gregh3...@gmail.com>
Subject Re: git commit: Make we sure we handle doubles/longs correctly, for class cast exception.
Date Wed, 05 Feb 2014 11:17:04 GMT
.. always fisticuffs, kind of like drinking someone's beer ;)


On 5 February 2014 10:12, Lukasz Lenart <lukaszlenart@apache.org> wrote:

> 2014-02-05 Greg Huber <gregh3269@gmail.com>:
> > ....To remember to check-in first before changing the code may be
> > problematic, ie forget to do it.  It is really only the diff where it
> > matters, cannot it be configured to ignore white space changes?
> >
> > git diff --ignore-space-change  ???
>
> Yes, I know it can be. But. When I apply some patch or modify a method
> I try to avoid reformatting code - I had disabled auto-format during
> commit and so on. And. When I have applied auto-format it doesn't mean
> that I solve the problem. Also git allows to perform small commits,
> solve one thing, commit, solve another, commit, finally you can solve
> the main problem, commit, etc. Before committing anything I'm trying
> review my changes with diff - it helps to spot stupid mistakes or
> leftovers.
>
> This is very helpful habit when you work with other languages than
> just pure Java - html, js, scala. Applying auto-formatting to these
> languages can make more harm than you thought :]
>
>
> Regards
> --
> Ɓukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message