struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Benitez <steven.beni...@gmail.com>
Subject Re: InterceptorListeners
Date Tue, 05 Nov 2013 14:45:43 GMT
I just wrote a long reply on why I don't think this API makes any sense and
how I don't follow the arguments in favor of it, but I scrapped it because
I could distill it down to the following:

"When in doubt, leave it out." -- Josh Bloch

Regards,
Steven


On Tue, Nov 5, 2013 at 9:23 AM, Ali Akhtar <ali.rac200@gmail.com> wrote:

> There's one case where it may be useful to have these listeners. Suppose if
> you have a lot of packages, and you just need to modify one or two
> interceptors in each package. You would have to paste your whole
> interceptor stack in order to do this.
>
> I think this feature could be useful for such cases.
>
>
> On Tue, Nov 5, 2013 at 7:13 PM, <umeshawasthi@gmail.com> wrote:
>
> > I am agree with Steven, existing API is really good.
> > We need to put more work of documents and showing user how to use or
> > modify existing API.
> >
> >
> >
> > Thanks
> > Umesh
> > Sent from BlackBerry® on Airtel
> >
> > -----Original Message-----
> > From: Steven Benitez <steven.benitez@gmail.com>
> > Date: Tue, 5 Nov 2013 09:00:14
> > To: Struts Developers List<dev@struts.apache.org>
> > Reply-To: "Struts Developers List" <dev@struts.apache.org>
> > Subject: Re: InterceptorListeners
> >
> > I feel pretty strongly that we should not broaden the API to accommodate
> > users who don't know how to use the existing API, which is really pretty
> > straight forward. We'd be better off educating users how the existing
> > interceptor API works rather than introducing new complexity.
> >
> >
> > On Tue, Nov 5, 2013 at 4:11 AM, Lukasz Lenart <lukaszlenart@apache.org
> > >wrote:
> >
> > > 2013/11/5 Steven Benitez <steven.benitez@gmail.com>:
> > > > Why not just create an interceptor and run it before or after the
> > > > interceptor you need? What specific use case does this address?
> > >
> > > You are perfectly right, it's the prefer way to achieve the same
> > behaviour.
> > >
> > > But there are some users which just stick with defaultStack or
> > > cannot/don't know how to modify the defaultStack - and it's solution
> > > just for them. Maybe I'm wrong and we should educated users to don't
> > > stick with default stack and always prepare their own stack (at least
> > > to improve performance).
> > >
> > >
> > > Regards
> > > --
> > > Łukasz
> > > + 48 606 323 122 http://www.lenart.org.pl/
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message