struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukaszlen...@apache.org>
Subject Re: excludeParams in ParamtersInterceptor
Date Fri, 18 Oct 2013 13:50:52 GMT
2013/10/18 Dave Newton <davelnewton@gmail.com>:
> On Fri, Oct 18, 2013 at 8:01 AM, Lukasz Lenart wrote:
>
>> Also changed order of methods in acceptableName() method to first
>> check "excludeParams" and then "acceptParams"
>>
>
> Meaning if it's in the exclude list it doesn't check accepted?

Yes,

boolean accepted = isWithinLengthLimit(name) && !isExcluded(name) &&
isAccepted(name);

The problem is with "method:" and "action:" prefixes which are added
to excludedParams list but doesn't match ACCEPTED_PARAM_NAMES and then
in the logs user see warning:

"Parameter [method:index] didn't match acceptedPattern pattern!"

which is a bit misleading. After switch, user will see:

"Parameter [method:index] is on the excludeParams list of patterns!"

which has more sense.


Regards
-- 
Ɓukasz
+ 48 606 323 122 http://www.lenart.org.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message