struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Luppens <philip.lupp...@gmail.com>
Subject Re: Performance issue -> next release
Date Thu, 13 Dec 2012 08:55:56 GMT
On Thu, Dec 13, 2012 at 7:43 AM, Lukasz Lenart <lukaszlenart@apache.org>wrote:

> 2012/12/12 Philip Luppens <philip.luppens@gmail.com>:
> > I'd say to go for it, but please do explain what the issue was for
> archival
> > reasons, since the original ticket[1] did not receive any update yet.
>
> Ok, you're right. The problem is related to my FileManager
> refactorings and introduced FileManagerFactory with default
> implementation
>
> ConfigurationManager#conditionalReload() from version 2.3.7 looks like
> this:
>
> public synchronized void conditionalReload(Container container) {
>     FileManager fileManager =
> container.getInstance(FileManagerFactory.class).getFileManager();
>     if (fileManager.isReloadingConfigs() || providersChanged) {
>     ........
> }
>
> so each time FileManager instance was looked up just to check if
> reloadConfigs flag is set to true, but right now it looks like this
> and the flag is checked directly
>
> public synchronized void conditionalReload(Container container) {
>     boolean reloadConfigs =
> Boolean.parseBoolean(container.getInstance(String.class,
> XWorkConstants.RELOAD_XML_CONFIGURATION));
>     if (reloadConfigs || providersChanged) {
>     ........
> }
>

Great, thank you very much for the writeup. I'm also in favor of a quick
release of 2.3.8 (I've just seen that AppFuse 2.2.1 was released with the
affected Struts 2.3.7).

Thanks again,

Phil


>
>
> Regards
> --
> Ɓukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>


-- 
"We cannot change the cards we are dealt, just how we play the hand." -
Randy Pausch

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message