struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Łukasz Lenart <lukasz.len...@googlemail.com>
Subject Re: Struts Portlet Plugin 2.3.3. Breaks Using Struts App As Both Portlet and Standalone Web App
Date Mon, 07 May 2012 10:24:13 GMT
Ignore this

2012/5/7 Łukasz Lenart <lukasz.lenart@googlemail.com>:
> Anyway, something is messed up. Regarding this:
>
>    @StrutsTagAttribute(description = "Specifies if this should be a
> portlet render or action URL. Default is \"render\". To create an
> action URL, use \"action\".")
>    public void setPortletUrlType(String portletUrlType) {
>        urlProvider.setPortletUrlType(portletUrlType);
>    }
>
> only two values are allowed: either render or action

I think the if case

 if (PortletActionContext.getPortletContext() == null ||
"none".equalsIgnoreCase(urlComponent.getPortletUrlType()))

should be reduced to

 if (PortletActionContext.getPortletContext() == null) {

as the same statement is used in other places to fallback to ServlertRenderer


Regards
-- 
Łukasz http://www.lenart.org.pl/
mobile +48 606 323 122, office +27 11 0838747
Warszawa JUG conference - Confitura http://confitura.pl/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message