struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wesley Wannemacher" <w...@apache.org>
Subject Re: Review Request: WW-3659 - strange <s:a/> behaviour with <s:include/> tag in the body
Date Tue, 05 Jul 2011 14:48:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1003/#review960
-----------------------------------------------------------


Lukasz, I'm not sure what makes this change backwards incompatible... I would say "ship it"
but I'm more curious about why moving this to the closing template would make a difference.
One thing that I noticed about the original issue is that the poster is setting the variable
in "page" scope, then attempting to access the variable from another page that is included.
I haven't spent time looking at the example war that the poster attached, but I will say this
- I don't have a problem with this change, but I might have a problem with the motivation
for making the change and I would also want to look closer at our UIBean and ClosingUIBean
if the opening template is rendered differently than the closing template.

- Wesley


On 2011-07-05 14:01:47, Lukasz Lenart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1003/
> -----------------------------------------------------------
> 
> (Updated 2011-07-05 14:01:47)
> 
> 
> Review request for Struts2.
> 
> 
> Summary
> -------
> 
> This change will solve https://issues.apache.org/jira/browse/WW-3659 but can be backward
incompatibile
> 
> 
> Diffs
> -----
> 
>   ./core/src/main/resources/template/simple/a-close.ftl 1141925 
>   ./core/src/main/resources/template/simple/a.ftl 1141925 
> 
> Diff: https://reviews.apache.org/r/1003/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukasz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message