struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukasz Lenart <lukasz.len...@googlemail.com>
Subject Re: org.apache.struts2.util.MakeIterator
Date Tue, 07 Jun 2011 15:25:09 GMT
Done, thanks!

2011/6/7 Jason Pyeron <jpyeron@pdinc.us>:
>> -----Original Message-----
>> From: Lukasz Lenart
>> Sent: Tuesday, June 07, 2011 2:23
>> To: Struts Developers List
>> Subject: Re: org.apache.struts2.util.MakeIterator
>>
>> 2011/5/30 Jason Pyeron <jpyeron@pdinc.us>:
>> > In the convert method:
>> >
>> >        } else if (value instanceof Enumeration) {
>> >            Enumeration enumeration = (Enumeration) value;
>> >            ArrayList list = new ArrayList();
>> >
>> >            while (enumeration.hasMoreElements()) {
>> >                list.add(enumeration.nextElement());
>> >            }
>> >
>> >            iterator = list.iterator();
>> >        } else {
>> >
>> >
>> > Why is a wrapper not being used? This is in effect doing double
>> > iteration, extra memory, etc.
>> >
>> > There is a wrapper in org.apache.struts2.util.IteratorFilterSupport:
>> > EnumerationIterator.
>> >
>> > Any reasons it should not be patched?
>>
>> Nop, I think it was simple oversight ;-)
>
> https://issues.apache.org/jira/browse/WW-3645
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> -                                                        
      -
> - Jason Pyeron                      PD Inc. http://www.pdinc.us -
> - Principal Consultant              10 West 24th Street #100    -
> - +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
> -                                                        
      -
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> This message is copyright PD Inc, subject to license 20080407P00.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message