struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Newton <newton.d...@yahoo.com>
Subject Re: Fileupload dependency, https://issues.apache.org/struts/browse/WW-2446
Date Sat, 19 Jan 2008 16:51:05 GMT
You asked that the discussion be moved to struts-dev, so I did.

S2 *does* have an out-of-the-box configuration; it's in default.properties.
It uses commons-fileupload, and it won't fail until runtime when using
<s:file.../>.

While your comment added to the upload interceptor is useful, it should be in
a {note} that says something along the lines of "the S2 <s:file...> tag will
not work until you've downloaded the default commons-fileupload dependency"
and added to the "how do we upload files?" FAQ entry.

This isn't a compile-time dependency; I'll get a runtime error as soon as I
use <s:file.../> with the default stack (that includes the interceptor).

d.

--- James Mitchell <jmitchtx@gmail.com> wrote:

> My comments on this can be found here:
>  https://issues.apache.org/struts/browse/WW-2446
> 
> On Jan 19, 2008 11:29 AM, Dave Newton <newton.dave@yahoo.com> wrote:
> > The <s:file.../> tag depends on an upload dependency being in place.
> >
> > The default S2 configuration uses commons-fileupload, which won't work
> with
> > the standard distribution, because we don't include fileupload.
> >
> > If we don't want to ship fileupload, then we should not make the default
> S2
> > configuration use it, because anybody using <s:file.../> will experience
> > failure at run-time because of the missing dependency.
> >
> > AFAIK this is the only situation in S2 where something provided in the
> > standard distro that isn't a plugin simply won't work until another
> > dependency is satisfied.
> >
> > d.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
> 
> 
> 
> -- 
> James Mitchell
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message