struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Newton <newton.d...@yahoo.com>
Subject Re: Fileupload dependency, https://issues.apache.org/struts/browse/WW-2446
Date Sun, 20 Jan 2008 02:03:47 GMT
--- James Mitchell <jmitchell@apache.org> wrote:
> (I renamed the subject to attract the attention of any devs who would
> likely have something to say about increasing the size of the distribution,

> but are probably not following this discussion)

Looks the same.

> I could be wrong (it's happened in the past, rarely :) , but that setting
> is not an out-of-the-box configuration.  It is simply a default setting 
> as to which multipart request impl to use.

Meh; "default" means "out-of-the-box" to me.

> If you create a Struts project and you drop in a <s:file> tag so that you
> can have file uploading in your app.  To me this means that you have
> "decided" to use File Upload functionality which (again, to me) is the 
> same as "deciding" to use jasper reports or "deciding" to use the jsf
> plugin.

If file uploading required the conscious decision to use a specific plugin,
I'd agree. But it doesn't, as it stands now. The way things stand now (modulo
your new file upload interceptor comment documentation) there's nothing in
the documentation that implies anything special must be done to support a
common-enough usecase.

> I think the confusion here is because file upload should be pulled into
> it's own plugin.

That's fine, although I still have to agree with Antonio that uploading a
file is common enough that it *should* work out of the the box without
additional dependencies. Pulling it in to a plugin would at least make it
clear that S2 doesn't support file uploading out of the box.

d.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message