Mailing-List: contact dev-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <dev@struts.apache.org>
Received-SPF: pass (herse.apache.org: domain of ted.husted@gmail.com
 designates 64.233.162.224 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=oVXr4OHeiR8PEmnZgMWrcJez9es+X1bXpV/4O1aH2Zt3XbZz23dfu4HbQa3FBbIIU7xPyaWHLlJDSZDBR1j7dkPeLc/HY+Ck8IbmDXXP1SKog+aj/aPVfCPUF+SzwSRV1UpB8Bx7aMKWDnwciCIGDLMT1Pb7ie8axXY4oAdvxZ8=
Message-ID: <8b3ce3790702110458q3b4d13wfb07197f87088f22@mail.gmail.com>
Date: Sun, 11 Feb 2007 07:58:45 -0500
From: "Ted Husted" <husted@apache.org>
Sender: ted.husted@gmail.com
To: "Struts Developers List" <dev@struts.apache.org>
Subject: Re: [VOTE] Struts 2.0.5 Quality
In-Reply-To: <adba96190702102047w1705ed38o87a2d8a00c40575a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <8b3ce3790702051011i32b5c87bs44d2bd1f63d233fd@mail.gmail.com>
	 <45CE9D74.5000100@gmail.com>
	 <adba96190702102047w1705ed38o87a2d8a00c40575a@mail.gmail.com>

On 2/10/07, Wendy Smoak <wsmoak@gmail.com> wrote:
> On 2/10/07, Tom Schneider <schneidh@gmail.com> wrote:
> > Umm, it looks like the spring plugin jar isn't included.  Someone on
> > #struts mentioned this and I confirmed it by downloading
> > struts-2.0.5-all.zip from the website and it's not in the lib
> > directory.  (All the other plugins are there)  Am I crazy or is it
> > really missing?
>
> If you've confirmed it, please open an issue against 2.0.5.  The file
> is probably missing from the assembly descriptor.
>
> --Wendy

Yes, both the Spring Plugin and Codebehind Plugin are missing from the
assembly POM.

Do we just want to

(1) note this as a known issue,
(2) branch on 2.0.5 and issue a 2.0.5.1 version of the lib and all
distributions.
(3) issue 2.0.6 from the 2.0.x branch.

I could do any of these things today. If we do (3), I would first drop
and recreate the 2.0.x tag from the 2.0.5 tag, so as to skip over the
changes that broke the HEAD after 2.0.5 was tag. (Last time I branch
the HEAD rather than a tag!)

Another build issue is that the TLD is being rewritten during the
assembly, I guess to reflect changes to the annotations. Should we be
running an assembly before the tag first, to look for TLD updates, and
checking those in, before continuing with the rest of the tag and
roll?


Index: struts-tags.tld
===================================================================
--- struts-tags.tld	(revision 503710)
+++ struts-tags.tld	(working copy)
@@ -2762,7 +2762,7 @@
       <name>doubleListKey</name>
       <required>false</required>
       <rtexprvalue>true</rtexprvalue>
-      <description><![CDATA[Set the list key of the second
attribute]]></description>
+      <description><![CDATA[The key expression to use for second
list]]></description>
     </attribute>
     <attribute>
       <name>doubleListValue</name>
@@ -5270,7 +5270,7 @@
       <name>doubleListKey</name>
       <required>false</required>
       <rtexprvalue>true</rtexprvalue>
-      <description><![CDATA[Set the list key of the second
attribute]]></description>
+      <description><![CDATA[The key expression to use for second
list]]></description>
     </attribute>
     <attribute>
       <name>doubleListValue</name>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org