struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Musachy Barroso <musa...@gmail.com>
Subject Re: taglib generation with xdoclet 2
Date Wed, 22 Nov 2006 02:14:58 GMT
That makes sense, but we don't need a maven plugin just for that right?, 
just a jar file with those classes will do.

musachy
Don Brown wrote:
> Well, you wouldn't want to include the code as if it was part of 
> core.  You'd want to turn it into its own maven plugin, publish it, 
> then have Struts 2 core use the plugin when it generates resources.   
> It should be possible to just checkout core and build it without 
> external path dependencies.
>
> Don
>
> Musachy Barroso wrote:
>> That's a good idea, I was using them inside core because it was 
>> easier :). Just change core's pom "includes" to something like:
>>
>> <includes>
>>    <include>**/*.java</include>
>>    <include>../maven/plugins/apt/......./*.java</include>
>> </includes>
>>
>> I just tried it and it works ok.
>>
>> musachy
>> James Mitchell wrote:
>>> Ya, we should probably move this to /struts/maven/plugins/ or 
>>> something similar.  Then we can just depend on it during build.
>>>
>>>
>>> -- 
>>> James Mitchell
>>> 678.910.8017
>>>
>>>
>>>
>>>
>>> On Nov 21, 2006, at 6:18 PM, Don Brown wrote:
>>>
>>>> Rene, is there any reason this code should go into Struts 2 core?
>>>> Does it need to referenced at runtime?  I thought you were using these
>>>> annotations at compile time, which AFAIK, means they won't be included
>>>> in the compiled code, so there would be no reason to include the
>>>> annotation code in the jar.
>>>>
>>>> I think this should be pushed out to a new Maven 2 plugin, perhaps
>>>> under /struts/maven instead of Struts 2.
>>>>
>>>> Don
>>>>
>>>> On 11/21/06, Rene Gielen <forum-struts-dev@opensymphony.com> wrote:
>>>>> I committed Musachy's patch with some modifications, so that the 
>>>>> annotations are in place as well as the apt generation code, so we 
>>>>> all can give it a review. Maybe we will have to do some more 
>>>>> changes, but it looks quite straight forward in the first place.
>>>>>
>>>>> Converting doc-tags to annotations is supposed to be a dirty job, 
>>>>> I've done some tests and will continue tomorrow. May the regexes 
>>>>> be with us ... :)
>>>>>
>>>>> Nonetheless, we still can work "on both ends", giving both the apt 
>>>>> and xd2 a try while having common meta information convention. I 
>>>>> was not able to look into Konstantins patch yet, but I will do 
>>>>> ASAP after doing the conversion stuff.
>>>>>
>>>>> Regards,
>>>>> Rene
>>>>>
>>>>> > I have everything working fine, but I'm waiting to
>>>>> > get home and retest
>>>>> > it on linux before submitting.
>>>>> >
>>>>> > musachy
>>>>> >
>>>>> > Ted Husted wrote:
>>>>> > > Likewise. Either will be fine with me. From the
>>>>> > other thread, I think
>>>>> > > Rene was going to look at apt again later today.
>>>>> > >
>>>>> > > -Ted.
>>>>> > >
>>>>> > > On 11/20/06, Don Brown <mrdon@twdata.org> wrote:
>>>>> > >> I believe whoever is planning on doing the actual
>>>>> > commit decides..... I
>>>>> > >> call "not it!" :)
>>>>> > >>
>>>>> > >> Don
>>>>> > >>
>>>>> > >> James Mitchell wrote:
>>>>> > >>
>>>>> > >> > I was under the impression that we were going to
>>>>> > use apt.
>>>>> > >> >
>>>>> > >> > --
>>>>> > >> > James Mitchell
>>>>> > >> > 678.910.8017
>>>>> > >
>>>>> > >> >
>>>>> > >> > On Nov 19, 2006, at 6:33 PM, Musachy Barroso
>>>>> > wrote:
>>>>> > >> >
>>>>> > >> >> Are we finally going to stick to xdoclet or use
>>>>> > annotations?  I  have
>>>>> > >> >> the
>>>>> > >> >> maven-apt plugin  almost ready(from tobago
>>>>> > project + some fixes)
>>>>> > >> >> with the
>>>>> > >> >> apt stuff, but I don't want to spend more time
>>>>> > on it if we are not
>>>>> > >> >> going to
>>>>> > >> >> use it.
>>>>> > >> >>
>>>>> > >> >> regards
>>>>> > >> >> musachy
>>>>> > >> >>
>>>>> > >> >> On 11/18/06, Konstantin Priblouda
>>>>> > <kpriblouda@yahoo.com> wrote:
>>>>> > >> >>
>>>>> > >> >>>
>>>>> > >> >>> HI all,
>>>>> > >> >>>
>>>>> > >> >>> I just created an issue containing patch to
>>>>> > pom.xml
>>>>> > >> >>> to enable tld-generation by xdoclet-2
>>>>> > >> >>> ( WW-1512 )
>>>>> > >> >>>
>>>>> > >> >>> feel free to ask questions.
>>>>> > >> >>>
>>>>> > >> >>> regards,
>>>>> > >> >>>
>>>>> > >> >>> ----[ Konstantin Pribluda
>>>>> > http://www.pribluda.de ]----------------
>>>>> > >> >>> Still using XDoclet 1.x?  XDoclet 2 is
>>>>> > released and of production
>>>>> > >> >>> quality.
>>>>> > >> >>> check it out: http://xdoclet.codehaus.org
>>>>> > >> >>>
>>>>> > >
>>>>> > >
>>>>> > ------------------------------------------------------
>>>>> > ---------------
>>>>> > > To unsubscribe, e-mail:
>>>>> > dev-unsubscribe@struts.apache.org
>>>>> > > For additional commands, e-mail:
>>>>> > dev-help@struts.apache.org
>>>>> > >
>>>>> > >
>>>>> >
>>>>> >
>>>>> > ------------------------------------------------------
>>>>> > ---------------
>>>>> > To unsubscribe, e-mail:
>>>>> > dev-unsubscribe@struts.apache.org
>>>>> > For additional commands, e-mail:
>>>>> > dev-help@struts.apache.org
>>>>> >
>>>>> >
>>>>> ---------------------------------------------------------------------
>>>>> Posted via Jive Forums
>>>>> http://forums.opensymphony.com/thread.jspa?threadID=50761&messageID=102782#102782

>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message