struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wendy Smoak" <wsm...@gmail.com>
Subject Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]
Date Sat, 26 Aug 2006 05:11:19 GMT
On 8/25/06, Paul Benedict <pbenedict@apache.org> wrote:

> I will add that to the bug report. Yes, those concerns have been
> addressed because the approach is different then the original idea.

OK, then the only other thing I'd suggest is to work this into one of
the example apps, and update the relevant part of the website
documentation, before closing the issue.

> Sorry about the re-ordering. I didn't think that would matter because
> imports come and go as I tried different things. But I guess it does
> matter. Commits are on a whole file basis, right? So I would have to fix
> those ordering before committing?

It matters in that it makes the commit messages harder to review.
You're likely to get a comment or two if there is a lot of noise in
your commit diffs. :)

-- 
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message