struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wendy Smoak" <wsm...@gmail.com>
Subject Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]
Date Sat, 26 Aug 2006 03:55:32 GMT
On 8/25/06, Paul Benedict <pbenedict@apache.org> wrote:

> I don't have any straight instructions on when it's appropriate to
> commit code, and so I have provided a patch. If anyone wants to test it
> out, please feel free. It works well for me both on the
> ComposableRequestProcessor and the ol' RequestProcessor.
>
> What's the next steps?

In general, we're commit-then-review, but if something might be
controversial it's a good idea to bring it up on the dev list first.
Which you did. :)

>From the comments on the issue, it looks like Craig has some
reservations about this idea.  You might want to add a comment to the
issue linking to the relevant mailing list thread(s) from November
'05.  Craig commented on the issue itself, but Martin must have
answered on the mailing list.  Have their concerns been addressed?

(The patch itself has some noise, reordering import statements.
Consider committing that separately so it doesn't distract from the
actual changes.)

HTH,
-- 
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message