struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Benedict <pbened...@apache.org>
Subject Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]
Date Sat, 26 Aug 2006 04:30:17 GMT
 From the comments on the issue, it looks like Craig has some
> reservations about this idea.  You might want to add a comment to the
> issue linking to the relevant mailing list thread(s) from November
> '05.  Craig commented on the issue itself, but Martin must have
> answered on the mailing list.  Have their concerns been addressed?
>
I will add that to the bug report. Yes, those concerns have been 
addressed because the approach is different then the original idea.
> (The patch itself has some noise, reordering import statements.
> Consider committing that separately so it doesn't distract from the
> actual changes.)
>
Sorry about the re-ordering. I didn't think that would matter because 
imports come and go as I tried different things. But I guess it does 
matter. Commits are on a whole file basis, right? So I would have to fix 
those ordering before committing?

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message