struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig McClanahan" <craig...@apache.org>
Subject Re: svn commit: r414249 - /struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
Date Wed, 14 Jun 2006 19:59:42 GMT
On 6/14/06, Don Brown <mrdon@apache.org> wrote:
>
> That makes sense too.  I guess the big draw for everything a JIRA ticket
> is it
> is easier to create the release notes.  If you are just fixing a typo,
> that
> probably wouldn't go in the release notes anyways.


That's exactly the standard I like to use to decide whether to file an issue
or not.  In general, fixing typos or improving Javadocs doesn't really rise
to that level of attention.  On the other hand, I'd prefer that pretty much
all changes to the actual code would be documented by an issue (unless,
perhaps, you are just fixing something you broke in a previous checkin
against an issue :-).

Don


Craig

Sean Schofield wrote:
> > Going back to my point about overkill.  If you have a complicated
> > problem that cannot be summarized in a sentence or two, yes, then
> > definitely a JIRA issue is in order.  But if its a bug that was not
> > reported by anyone and it was introduced in the current release cycle
> > (say a tweak to a Maven POM) putting the info in JIRA is overkill.
> >
> > The *first* place I check when I want to understand a file change is
> > the SVN logs.  If there is a JIRA ref there then I go to JIRA.
> > Usually the one line comment is sufficent for me to understand why the
> > change was made.
> >
> > Again, if its in reference to a bug that has already been reported
> > obviously you use JIRA.  Also for any kind of major change (even if
> > introduced in the current cycle) then JIRA is also appropriate.
> >
> > Sean
> >
> > On 6/14/06, Ted Husted <ted.husted@gmail.com> wrote:
> >> We have a ticket up for the current round of documentation updates
> >> [WW-1340]  so you can use that.
> >>
> >> -Ted.
> >>
> >> On 6/14/06, tm jee <tm_jee@yahoo.co.uk> wrote:
> >> > Okie dokie. Thx for the reminder.
> >> >
> >> > Do we need to create a jira issue even if its just changing some
> >> javadoc, like typo or snippet id is wrongly assigned etc.?
> >> >
> >> > regards.
> >> >
> >> > ----- Original Message ----
> >> > From: Don Brown <mrdon@twdata.org>
> >> > To: dev@struts.apache.org
> >> > Sent: Thursday, 15 June, 2006 1:16:48 AM
> >> > Subject: Re: svn commit: r414249 -
> >>
> /struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
> >>
> >> >
> >> > Don't forget to associate a JIRA ticket with each commit to make it
> >> easier to
> >> > track changes in a release... :)
> >> >
> >> > Thanks,
> >> >
> >> > Don
> >> >
> >> > tmjee@apache.org wrote:
> >> > > Author: tmjee
> >> > > Date: Wed Jun 14 06:48:08 2006
> >> > > New Revision: 414249
> >> > >
> >> > > URL: http://svn.apache.org/viewvc?rev=414249&view=rev
> >> > > Log:
> >> > > - added javadoc & snippet to reflect the fact that if JSP template
> is
> >> > >   being used, it should resides in the webapp not the classpath as
> >> JSP
> >> > > is not capable of being picked up from classpath unlike Freemarker
> or
> >> > > Velocity
> >> > >
> >> > >  see
> >> http://forums.opensymphony.com/thread.jspa?threadID=33869&tstart=0
> >> > >
> >> > >
> >> > > Modified:
> >> > >
> >>
> struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
> >>
> >> > >
> >> > > Modified:
> >>
> struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
> >>
> >> > > URL:
> >>
> http://svn.apache.org/viewvc/struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java?rev=414249&r1=414248&r2=414249&view=diff
> >>
> >> > >
> >>
> ==============================================================================
> >>
> >> > > ---
> >>
> struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
> >> (original)
> >> > > +++
> >>
> struts/action2/trunk/core/src/main/java/org/apache/struts/action2/components/GenericUIBean.java
> >> Wed Jun 14 06:48:08 2006
> >> > > @@ -47,6 +47,7 @@
> >> > >   *
> >> > >   *
> >> > >   * @a2.tag name="component" tld-body-content="JSP"
> >> tld-tag-class="org.apache.struts.action2.views.jsp.ui.ComponentTag"
> >> > >   * description="Render a custom ui widget"
> >> > >
> >> > >
> >> > >
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> > For additional commands, e-mail: dev-help@struts.apache.org
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >>
> >> --
> >> HTH, Ted.
> >> * http://www.husted.com/struts/
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message