struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Lee" <crazy...@crazybob.org>
Subject Re: Messages Round II (was Leveraging known constructs (was Public API firs
Date Fri, 05 May 2006 19:30:11 GMT
I'm cool with that. Sticking with verbs, there's also err(), warn(),
inform(). ;)

Bob

On 5/5/06, Jason Carreira <forum-struts-dev@opensymphony.com> wrote:
> Yeah, I generally like it, but I still prefer the more obvious addError(), addWarning().
I like my methods as verbs... makes reading the code easier (to me).
>
> > - The attached version supports arbitrary levels. I
> > used an interface
> > instead of an enum so the user can define additional
> > levels if they
> > wish. Should Level extend Comparable?
> >
> > - It has built in support for INFO, WARN, and ERROR
> > along with
> > respective convenience methods.
> >
> > - It provides a Map of field messages. It's not
> > necessary for Messages
> > itself to implement both Map and List. Delegating to
> > separate objects
> > is less confusing.
> >
> > - Adding messages and checking for the presence of
> > messages
> > (hasErrors()) should be dead simple. Getting the
> > messages doesn't have
> > to be as convenient (at least not through the
> > published API).
> >
> > - "Request-scoped" is the wrong word. We're really
> > talking about "not
> > associated with a field." Page-scoped? Form-scoped?
> > Global?
> >
> > Thanks,
> > Bob
> > ------------------------------------------------------
> > ---------------
> > To unsubscribe, e-mail:
> > dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail:
> > dev-help@struts.apache.org
> ---------------------------------------------------------------------
> Posted via Jive Forums
> http://forums.opensymphony.com/thread.jspa?threadID=29554&messageID=57361#57361
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message