struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Cooper (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STR-2858) chain-config.xml file should be explicitly referenced from web.xml file
Date Fri, 05 May 2006 02:57:21 GMT
    [ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37274 ] 

Martin Cooper commented on STR-2858:
------------------------------------

There are two quite separate uses of Chain here, and I believe we should treat them differently.

The first use is the request processor chain itself. As Don mentions, the vast majority of
users won't need to know or care about this. In fact, making it too obvious might lead people
to start messing with it wtthout understanding it, so IMHO it's better kept out of the way.

The second use is where the application itself is taking advantage of chains. Here, the chain
config file should certainly be readily available, since this is the file that users are going
to be modifying. For any examples we provide, I agree that this file should be in an obvious
location, to help people understand how the app works.

While it's possible to combine both of these uses in a single chain config file, I don't think
that would be wise. Separation of concerns and all that.

> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
>          Key: STR-2858
>          URL: http://issues.apache.org/struts/browse/STR-2858
>      Project: Struts Action 1
>         Type: Improvement

>   Components: Apps
>     Versions: 1.3.2
>     Reporter: Michael Jouravlev
>     Priority: Trivial

>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file
instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml.
As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to
decrease amount of "magic".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message