Return-Path: Delivered-To: apmail-struts-dev-archive@www.apache.org Received: (qmail 6889 invoked from network); 15 Apr 2006 16:50:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Apr 2006 16:50:29 -0000 Received: (qmail 36538 invoked by uid 500); 15 Apr 2006 16:50:26 -0000 Delivered-To: apmail-struts-dev-archive@struts.apache.org Received: (qmail 36493 invoked by uid 500); 15 Apr 2006 16:50:26 -0000 Mailing-List: contact dev-help@struts.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Struts Developers List" Reply-To: "Struts Developers List" Delivered-To: mailing list dev@struts.apache.org Received: (qmail 36481 invoked by uid 99); 15 Apr 2006 16:50:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2006 09:50:26 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [216.228.2.15] (HELO mail-fs2.redshift.com) (216.228.2.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2006 09:50:24 -0700 Received: (qmail 82062 invoked by uid 89); 15 Apr 2006 16:50:05 -0000 Received: by simscan 1.2.0 ppid: 82057, pid: 82059, t: 0.3506s scanners: attach: 1.2.0 clamav: 0.88/m:36/d:1360 Received: from unknown (HELO noobs.twdata.org) (216.228.28.196) by mail-smtp.redshift.com with SMTP; 15 Apr 2006 16:50:05 -0000 Received: from [192.168.0.3] (unknown [192.168.0.3]) by noobs.twdata.org (Postfix) with ESMTP id 6B5BCA0D90BC for ; Sat, 15 Apr 2006 09:50:02 -0700 (PDT) Message-ID: <44412485.60700@twdata.org> Date: Sat, 15 Apr 2006 09:51:17 -0700 From: Don Brown User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Struts Developers List Subject: Re: svn commit: r394308 - in /incubator/webwork2/action/src/test: java/org/apache/struts/action2/views/jsp/ui/ resources/org/apache/struts/action2/views/jsp/ui/ References: <20060415154503.80783.qmail@minotaur.apache.org> In-Reply-To: <20060415154503.80783.qmail@minotaur.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thanks Toby for fixing these tests. I keep forgetting WebWork, even its tags, are so well unit tested :) Don tmjee@apache.org wrote: > Author: tmjee > Date: Sat Apr 15 08:45:00 2006 > New Revision: 394308 > > URL: http://svn.apache.org/viewcvs?rev=394308&view=rev > Log: > - fix failing test case > > > Modified: > incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt > incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt > > Modified: incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java (original) > +++ incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java Sat Apr 15 08:45:00 2006 > @@ -23,7 +23,9 @@ > import org.apache.struts.action2.config.Configuration; > import org.apache.struts.action2.views.jsp.AbstractUITagTest; > import org.apache.struts.action2.views.jsp.ActionTag; > + > import com.opensymphony.xwork.ActionContext; > +import com.opensymphony.xwork.ObjectFactory; > import com.opensymphony.xwork.config.ConfigurationManager; > > > @@ -31,13 +33,15 @@ > * FormTagTest > * > * @author Jason Carreira > - * Created Apr 3, 2003 10:28:58 AM > + * @author tm_jee > * > * @version $Date$ $Id$ > */ > public class FormTagTest extends AbstractUITagTest { > > public void testForm() throws Exception { > + ObjectFactory.setObjectFactory(new MyObjectFactory()); > + > request.setupGetServletPath("/testAction"); > > TestAction testAction = (TestAction) action; > @@ -363,4 +367,8 @@ > ConfigurationManager.addConfigurationProvider(new TestConfigurationProvider()); > ActionContext.getContext().setValueStack(stack); > } > + > + static class MyObjectFactory extends ObjectFactory { > + > + } > } > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,6 @@ > > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt Sat Apr 15 08:45:00 2006 > @@ -28,6 +28,10 @@ > selectUnselectMatchingOptions(updownselectObj, null, "unselect", false, "key"); > } > > + > + > + > + > > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,7 @@ > > + > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,7 @@ > > + > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,7 @@ > > + > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt Sat Apr 15 08:45:00 2006 > @@ -28,3 +28,6 @@ > } > > > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,7 @@ > > + > + > + > + > > Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt > URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt?rev=394308&r1=394307&r2=394308&view=diff > ============================================================================== > --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt (original) > +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt Sat Apr 15 08:45:00 2006 > @@ -6,3 +6,7 @@ > > + > + > + > + > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org > For additional commands, e-mail: dev-help@struts.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org For additional commands, e-mail: dev-help@struts.apache.org