struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Evans (JIRA)" <j...@apache.org>
Subject [jira] Closed: (STR-2049) processNoCache() method does not expire properly
Date Mon, 24 Apr 2006 19:12:10 GMT
     [ http://issues.apache.org/struts/browse/STR-2049?page=all ]
     
David Evans closed STR-2049:
----------------------------

    Resolution: Fixed

> processNoCache() method does not expire properly
> ------------------------------------------------
>
>          Key: STR-2049
>          URL: http://issues.apache.org/struts/browse/STR-2049
>      Project: Struts Action 1
>         Type: Bug

>   Components: Action
>     Versions: Nightly Build
>  Environment: Operating System: other
> Platform: Other
>     Reporter: Haroon Rafique
>     Assignee: David Evans
>      Fix For: 1.2 Family
>  Attachments: proper-cache-control.diff
>
> processNoCache() method does not expire properly.
> The Cache-Control header is set by processNoCache() method in RequestProcessor
> as follows:
>             response.setHeader("Cache-Control", "no-cache");
> With IE everything is fine. Hitting the back button works wonderfully and if the
> previous request was a GET it would be "re GOTTEN" and if it was a POST, it
> displays the "POST data has expired warning. U wanna resubmit?" dialog.
> However, for some other browsers, it doesn't quite work.
> In Galeon and mozilla, regardless of whether the HTTP request was a POST or a
> GET, hitting the back button shows the previous screen in its original glory
> (not good).
> I made a slight tweak and over-rode the processNoCache() method in "my
> RequestProcessor" (which incidentally overrides TilesRP). Inside this
> overriddent, I changed the Cache-Control setting to:
>             response.setHeader("Cache-Control", "no-cache,no-store,max-age=0");
> After this IE, galeon, mozilla, netscape 7, all were correctly either re-GETting
> the GET request or posting a warning about re-POSTing the POST request when the
> back button was hit.
> Could this modification be made directly in
> src/share/org/apache/struts/action/RequestProcessor.java, please? I don't see
> any side-effects (yet :-)).
> I see from the annotation history that this line has been in this file since the
> intial commit (2 years, 3 months ago) done by craigmcc. Craig, do you have any
> thoughts?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message