struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34533] - Specify which module is causing an error in ModuleUtils.selectModule()
Date Wed, 29 Mar 2006 17:52:09 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34533>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34533





------- Additional Comments From bayard@apache.org  2006-03-29 18:52 -------
Should it maybe just do a return; in the else block (after removing)?

The code in the latest 1.2.x is the same, so there's no change from 1.2.4. 

So options seem to be:

1) Throw an Exception, because not having a ModuleConfig is bad.
2) Log an error, because not having a ModuleConfig is bad.
3) Add a return; (ie: null protect the later code); because not having an MC is fine, the
code is just a bit 
sloppy.
4) Add a return; and log a warning; because not having an MC is probably not wanted.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message