struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
Date Thu, 16 Feb 2006 04:04:54 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38374>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38374





------- Additional Comments From paul4christ79@yahoo.com  2006-02-16 05:04 -------
Ted writes: In Struts Action 1.3.0, the exception handling is done through a
"filter" that always fires (like a finally clause), so the patch is
not necessary.

As part of adding the new cancel handling,  we added a new html-cancel
page to "Exercises" that tests and demonstrates the new behavior,
including use of a custom ExceptionHandler. All the other bundled
applications have been updated to set cancellable where needed, and I
confirmed that cancellable did need to be set first. So, not to worry,
the code is good to go!

Paul writes: I'll take your word for it, except I am forced to disagree by
looking at the code. Did you only test 1.3 with the ComposableRequestProcessor?
The original RequestProcessor still has this loophole that needs to be closed.
That's what this patch is for. I don't see any code for a "filter" in 1.3 RP
unless you mistakened this path for the CRP.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message