struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34849] - Expression Language Field Validator
Date Wed, 11 May 2005 02:44:49 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34849>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34849





------- Additional Comments From niallp@apache.org  2005-05-11 04:44 -------
There are a number of reasons why validwhen has been a pain:

1) Its not supported by the original author and pretty much anyone else.
2) Inadequate documentation and no examples in the examples webapp.
3) No unit tests provided.
4) Debugging when it goes wrong was a real pain.

I never personally use validwhen, but since it has been "released" have felt 
obliged to support it. In order that we don't face a similar situation with 
this JEXL validator I would be -1 to including it unless the above issues are 
addressed for it.

I agree that we don't want a dependency on JSTL just because of EnumeratedMap. 
Especially since we wouldn't be able to distribute a jar for it, since there 
are different JSTL versions for Servlet 2.3 and Servlet 2.4.

Seems to me that since it is completely servlet dependant, it doesn't really 
fit in Commons Validator, so IMO it would be better off in struts. Also any 
docs need to make it clear that no client side validation will be generated.

I agree with you Joe in the validator name - jexl would be better. Also IMO its 
better if the param name is different to the validator name - that way it is 
less confusing what you're talking about when someone has it configured 
wrongly. How about "test" for the parameter - same as validwhen (anyone would 
have to be mad to use both validators for the same field!)

Having said all that - I agree, looks better than validwhen, but since I hate 
validwhen thats not saying alot!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message