struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Holmes" <ja...@jamesholmes.com>
Subject RE: DO NOT REPLY [Bug 28668] - struts-faces nightlies are empty
Date Wed, 09 Jun 2004 02:06:04 GMT
Well, it looks like my patches for 29219 will break the nightly build so I
am reverting them.

-James

-----Original Message-----
From: Niall Pemberton [mailto:niall.pemberton@blueyonder.co.uk] 
Sent: Tuesday, June 08, 2004 8:29 PM
To: Struts Developers List
Subject: Re: DO NOT REPLY [Bug 28668] - struts-faces nightlies are empty

Actually it was good. Until your thread I'd assumed struts-faces was failing
against the the current source. You saying it complied made me go look at
the source and old messages to try and understand what was going on.....and
the patch I originally posted to bugzilla didn't include changing
struts-faces back (as it had been changed to make it compatible with current
source). If I'd applied it, struts-faces wouldn't have compiled against any
version of Struts!

I hadn't realized that when I was building struts, it wasn't doing the
contrib stuff as well. Anyway, it was a good catch.

Thanks

Niall

----- Original Message ----- 
From: "James Holmes" <james@jamesholmes.com>
To: "'Struts Developers List'" <dev@struts.apache.org>
Sent: Wednesday, June 09, 2004 2:14 AM
Subject: RE: DO NOT REPLY [Bug 28668] - struts-faces nightlies are empty


> You're right.  My bad.  I didn't realize that you're patches had changes
to
> the struts-faces code until I just looked at the commits.  The
struts-faces
> code does indeed compile against struts 1.1.
>
> Ok, now I need to go and double check that the changes I commited to
> struts-faces today do not break the compilability against 1.1.
>
> -James
>
> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@blueyonder.co.uk]
> Sent: Tuesday, June 08, 2004 7:52 PM
> To: Struts Developers List
> Subject: Re: DO NOT REPLY [Bug 28668] - struts-faces nightlies are empty
>
> "James Holmes" wrote...
>
>
> > Yes, we will need to check this in the morning because I'm not convinced
> > that closing 22207 will fix the nightly struts-faces issue.  I say this
> > because I was able to get struts-faces to build fine today without the
> 22207
> > fixed being applied.
> >
> > We'll see...
>
> But were you building it against Struts 1.1, because I understand (from
what
> Craig said) the struts-faces is being built against Struts 1.1 which is
were
> the compatibility issue lies - building against the current struts source
is
> fine. Problem is I don't know where to look to verify that - I guess you
> would need to look locally at the build script on the machine that builds
> the nightlies, wherever that is?
>
> Anyway I agree I didn't want to get ahead of myself and change it to
> resolved until its proved to work.
>
> >
> > Thanks for taking care of 22207 and welcome!
> > -James
>
>
> Thanks :-)
>
> Niall
>
> >
> > -----Original Message-----
> > From: bugzilla@apache.org [mailto:bugzilla@apache.org]
> > Sent: Tuesday, June 08, 2004 7:33 PM
> > To: dev@struts.apache.org
> > Subject: DO NOT REPLY [Bug 28668] - struts-faces nightlies are empty
> >
> > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
> > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> > <http://issues.apache.org/bugzilla/show_bug.cgi?id=28668>.
> > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
> > INSERTED IN THE BUG DATABASE.
> >
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=28668
> >
> > struts-faces nightlies are empty
> >
> >
> >
> >
> >
> > ------- Additional Comments From niall.pemberton@blueyonder.co.uk
> > 2004-06-09 00:33 -------
> > The problem was it wouldn't compile against Struts 1.1
> >
> > I've applied the patch for Bug 22207, I'll leave the status as it is
until
> > the
> > next nightly has been generated.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Mime
View raw message