struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Germuska <...@Germuska.com>
Subject Re: [18111] et al
Date Tue, 20 Jan 2004 14:18:35 GMT
At 11:37 PM -0500 1/19/04, Ted Husted wrote:
>In reference to
>
><http://issues.apache.org/bugzilla/show_bug.cgi?id=18111>
>
>which I also gathered under
>
><http://issues.apache.org/bugzilla/show_bug.cgi?id=25855>.
>
>The suggestion is to add "contextRelative" to rewrite, as we just 
>did for img. The usecase being the sharing of common resources 
>between modules.
>
>Since rewrite extends link, I'm tempted to put the contextRelative 
>code into link. This change would seem to allow direct links between 
>modules.
>
>I don't remember if we discussed that before or not, so wanted to 
>send up a flare before proceeding.
>
>The one other remaining task is a fixing the pagePattern for img 
><http://issues.apache.org/bugzilla/show_bug.cgi?id=23127>.
>
>If we decide to allow contextRelative links, as a refactoring, I may 
>try a base "PathTag" to encapsulate the contextRelative and 
>pagePattern code. Link, Rewrite, Img and so forth, can then extend 
>"PathTag".
>
>These two tasks (#18111 and #23127) could conceivably be wrapped up 
>tomorrow, meaning we could roll 1.2.0 this weekend, if that sounds 
>all right. :)

I can't think of any reason to block direct links between modules; I 
can't speak for others, but our use cases for modules turn out to be 
much less strictly segregated than was apparently the intent of the 
original design, given how complicated certain things turn out to be.

I can use context-relative html:rewrite as soon as you check it in -- 
I was just wrestling with its absence last night.   Also, I would 
argue that the "switch action" is too much overhead for its own good 
-- and your proposed change would allow us to skip it also.

Joe

-- 
Joe Germuska            
Joe@Germuska.com  
http://blog.germuska.com    
       "Imagine if every Thursday your shoes exploded if you tied them 
the usual way.  This happens to us all the time with computers, and 
nobody thinks of complaining."
             -- Jef Raskin

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message