struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Mitchell <jmitch...@apache.org>
Subject Re: [18111] et al
Date Tue, 20 Jan 2004 16:06:26 GMT
[James Mitchell writes:]

In past projects, I have always recommended NOT to use Modules simply
because of the side effects (image references, rewrites, etc).  If I
understand what you are suggesting, it seems that your changes would fix all
of the above.

I am +1 for the changes.

+1 - meaning I will also help where I can...like....more tests...just let me
know.



--
James Mitchell
Software Engineer / Struts Evangelist
http://www.struts-atlanta.org
678.910.8017 (cell)
AIM:jmitchtx



----- Original Message -----
From: "Ted Husted" <husted@apache.org>
To: <struts-dev@jakarta.apache.org>
Sent: Monday, January 19, 2004 11:37 PM
Subject: [18111] et al


In reference to

<http://issues.apache.org/bugzilla/show_bug.cgi?id=18111>

which I also gathered under

<http://issues.apache.org/bugzilla/show_bug.cgi?id=25855>.

The suggestion is to add "contextRelative" to rewrite, as we just did for
img. The usecase being the sharing of common resources between modules.

Since rewrite extends link, I'm tempted to put the contextRelative code into
link. This change would seem to allow direct links between modules.

I don't remember if we discussed that before or not, so wanted to send up a
flare before proceeding.

The one other remaining task is a fixing the pagePattern for img
<http://issues.apache.org/bugzilla/show_bug.cgi?id=23127>.

If we decide to allow contextRelative links, as a refactoring, I may try a
base "PathTag" to encapsulate the contextRelative and pagePattern code.
Link, Rewrite, Img and so forth, can then extend "PathTag".

These two tasks (#18111 and #23127) could conceivably be wrapped up
tomorrow, meaning we could roll 1.2.0 this weekend, if that sounds all
right. :)

-Ted.




---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message