struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Cooper <mart...@apache.org>
Subject Re: @author tags in Struts code
Date Sat, 10 Jan 2004 18:04:08 GMT
On Fri, 9 Jan 2004, Paul Sundling wrote:

> That means a lot coming from you Craig!
>
> I want to get some feedback on some other changes I'd like to suggest:
>   on http://jakarta.apache.org/struts/volunteers.html (volunteer.xml)
> the current section order is:
>   Source Code Contributers
>   Documentation Contributers
>   Active Committers
>   Emeritus Committers
>
>   how about reordering the sections to
>   Active Committers
>   Emeritus Committers
>   Source Code Contributers
>   Documentation Contributers
>
> I don't know if there's already some other convention on that, but
> developers are listed before contributers in project.xml, so it seems
> like a logical ordering.  It also highlights those first who made very
> important contributions.

I'm not sure how the list originally got into the order it is in today,
but I have a theory. ;-) If we put non-committers first, it might give
newcomers more visibility, encouraging them to keep contributing, and
eventually, perhaps, become committers. Also, since "emeritus" committers
are not really around Struts any more, it kinda makes sense for them to be
at the bottom of the page.

That said, however, I don't have a problem with changing the order as you
describe.

>
> I noticed that a couple of active committers were not listed in the
> source code contributers!  That will be fixed when I update the list.
> This includes James Mitchell, Joe Germuska and David M. Karr.***

I have a theory about how this happened as well. ;-) We have not always
been prompt and religious about updating the lists, but I suspect we've
always added new committers fairly promptly. Hence the names listed in the
committers list who are not listed elsewhere. On the other hand, I'm not
sure how important it is for committers to be also listed as source and/or
documentation contributors, since it's sort of assumed. Those who are
listed as both probably got there by being added to the contributors list
prior to becoming committers, rather than the other way around. ;-)

But again, I have no objection to ensuring that all of the committers are
also listed as contributors.

>
> *I'm grabbing all the author tags under /src.  Should the same be done
> under contrib as well?  The scope of files involved in src is already
> several hundred, so If that's required I'll do that seperately as a
> seperate item.

Ultimately, yes, I think authors of code under contrib should be
recognised in the same way as authors in the rest of the code base. We
have, after all, accepted the code into the Struts repo, even if not (yet)
into the core itself.

But, as we say here, it's your itch, so however you wish to scratch it -
or not - is entirely up to you. (Which is just another way of saying feel
free to do this however you want, or not at all.)

>
> I think it would be good to mention the new policy on @author tags and
> that we're including people on the volunteer page in the documentation
> on how to help.  Anyone have some good wording for that?

Not off the top of my head, but I agree it's a good idea.

--
Martin Cooper


>
> Paul Sundling
>
> Craig R. McClanahan wrote:
>
> >Quoting Paul Sundling <tomcatlist@tkz.net>:
> >
> >
> >
> >>If the group was interested in removing all author tags and
> >>consolidating all the names onto volunteer.html I would be willing to
> >>make a tar of patches or whatever format is most convenient. If you're
> >>interested, let me know if that would be useful and I'll try to give you
> >>24 hour or less tournaround time. I'd probably have to ask for couple
> >>questions and then I'd submit it through bugzilla. It's in the realm of
> >>busy work, but I'm very detail oriented and pretty good with a CLI. :)
> >>
> >>
> >>
> >
> >+1 on such a patch, attached to a Bugzilla ticket in "cvs diff -u" format as
> >David pointed out.
> >
> >Ironically, this would definitely count as enough work to get you added to the
> >contributor list if you are not already :-).
> >
> >
> >
> >>Paul Sundling
> >>
> >>
> >
> >Craig
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message