Mailing-List: contact struts-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <struts-dev@jakarta.apache.org>
Message-ID: <3F2AA2C8.4030604@apache.org>
Date: Fri, 01 Aug 2003 13:26:32 -0400
From: Rob Leland <rleland@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.4) Gecko/20030624
MIME-Version: 1.0
To: Struts Developers List <struts-dev@jakarta.apache.org>
Subject: Re: Addition of two new actions
References: <20030801171029.38311.qmail@web20708.mail.yahoo.com>
In-Reply-To: <20030801171029.38311.qmail@web20708.mail.yahoo.com>
Content-Type: multipart/alternative;
 boundary="------------040508000909070303090801"

--------------040508000909070303090801
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

David Graham wrote:

>--- Rob Leland <rleland@apache.org> wrote:
>  
>
>>David Graham wrote:
>>
>>    
>>
>>>--- Rob Leland <rleland@apache.org> wrote:
>>> 
>>>
>>>      
>>>
>>>>Ted Husted wrote:
>>>>
>>>>   
>>>>
>>>>        
>>>>
>>>>>I use many utilities Actions like these, and the result is that fewer
>>>>>          
>>>>>
>>>>>*custom* Actions are needed. I think increasing the number of
>>>>>          
>>>>>
>>standard
>>    
>>
>>>>>     
>>>>>
>>>>>Actions in the distribution is a very good idea. It makes Struts more
>>>>>          
>>>>>
>>>>>accessible to newcomers, saves everyone from reimplementing the same 
>>>>>design, and leverages the fact that Actions are singletons.
>>>>>
>>>>>-Ted. 
>>>>>     
>>>>>
>>>>>          
>>>>>
>>>>How about struts-tools distribution named after the velocity-tools.
>>>>These would be classes that could be used stand-alone or in pairs.
>>>>Tnen we could place those orphan RequestUtils absoluteURL, and other
>>>>utilities there.
>>>>It would have a package structure o.a.s.tools.(util, actions, ....)
>>>>   
>>>>
>>>>        
>>>>
>>>I think unused methods/classes should be deprecated and removed.  We
>>>shouldn't be carrying around excess unused utility code just because a
>>>user *might* be using them.
>>> 
>>>
>>>      
>>>
>>I agree they should be moved from the core package.
>>And moved to an optional package.
>>    
>>
>
>I have a few concerns with this.  First, it's more work to maintain this
>new optional package with build files, tests, distribution, etc.  Second,
>it's likely that the unused code would decay because Struts isn't using
>it.  
>
Since we don't currently have a struts-contrib or struts-tools 
distribution I would agree.
Once that is in place I believe that would change.

>Also, it's confusing to have some actions in o.a.s.tools.actions and
>some in o.a.s.actions.  I think *all* standard actions that are
>distributed with Struts should live in o.a.s.actions.
>
or moved into the tools jar. I agree with what you said :
"I think unused methods/classes should be deprecated and removed."

If the struts core doesn't use it then it doesn't belong in the core, 
and should be
moved to a seperate jar. That includes any actions

>
>David
>


-- 
-----
Rob Leland (703-525-3580)


Choose a job you love, and you will never have to work a day of your life.
                                                                                      -Confucius.


--------------040508000909070303090801--