struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Raeburn" <sraeb...@apache.org>
Subject RE: Addition of two new actions
Date Fri, 01 Aug 2003 20:13:02 GMT
ParameterDispatchAction fulfils much the same function as
LookupDispatchAction but its implementation is almost identical to
DispatchAction.

It would be redundant to go through getKeyMethodMap() to get the method name
because it is supplied in the parameter. I may have misunderstood what you
are suggesting but to me it would make more sense to add to DispatchAction
than to Lookup DispatchAction.

It *may* make some sense to combine all three resolution methods into
DispatchAction and either have DispatchAction try to find a handler using
all three methods or set the method via a configuration parameter.

I worry that that would be more confusing to the user that having three
distinct classes that you can explain quite simply:

To dispatch to a method identified via a request parameter, use
DispatchAction.
To dispatch to a method based on which button was clicked, use
LookupDispatchAction
To dispatch to a method based on the action path, use
ParameterDispatchAction

I would prefer to add ParameterDispatchAction now and defer a decision about
merging the three actions.
To me, that would be 'the simplest thing that could possibly work' :-)

Steve


> -----Original Message-----
> From: Craig R. McClanahan [mailto:craigmcc@apache.org]
> Sent: August 1, 2003 10:42 AM
> To: Struts Developers List; sraeburn@apache.org
> Subject: RE: Addition of two new actions
>
>
> So, what you really want is LookupDispatchAction without requiring the
> developer to create the map-related methods?  I think you already get the
> abililty to combine CRUD related actions and things like that.  If so,
> then implementing a default getKeyMethodMap() in LookupDispatchAction
> might accomplish the same goal, without requiring another action.  Such a
> default implementation could examine the current LookupDispatchAction
> subclass and create the mapping information automatically.
>
> Don't get me wrong ... I like the idea behind what you're proposing.  I
> just think we might already have it (with the potential to improve ease of
> use by not forcing people to implement getKeyMethodMap() for a common use
> case).
>
>
> Craig



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message