struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Graham <grahamdavid1...@yahoo.com>
Subject Re: Addition of two new actions
Date Fri, 01 Aug 2003 19:47:36 GMT
--- Rob Leland <rleland@apache.org> wrote:
> David Graham wrote:
> 
> >>>I have a few concerns with this.  First, it's more work to maintain
> >>>      
> >>>
> >>this
> >>    
> >>
> >>>new optional package with build files, tests, distribution, etc. 
> >>>      
> >>>
> >>Second,
> >>    
> >>
> >>>it's likely that the unused code would decay because Struts isn't
> using
> >>>it.  
> >>>
> >>>      
> >>>
> >>Since we don't currently have a struts-contrib or struts-tools 
> >>distribution I would agree.
> >>Once that is in place I believe that would change.
> >>
> >>    
> >>
> >>>Also, it's confusing to have some actions in o.a.s.tools.actions and
> >>>some in o.a.s.actions.  I think *all* standard actions that are
> >>>distributed with Struts should live in o.a.s.actions.
> >>>
> >>>      
> >>>
> >>or moved into the tools jar. I agree with what you said :
> >>"I think unused methods/classes should be deprecated and removed."
> >>
> >>If the struts core doesn't use it then it doesn't belong in the core, 
> >>and should be
> >>moved to a seperate jar. That includes any actions
> >>    
> >>
> >
> >
> >So you're proposing that all of the current actions be separated from
> the
> >standard Struts distro jar? 
> >
> Yes, and if it is documented and deprecated over enough time, then by 
> struts 1.4 they could be removed.
> It's one way to get a lean struts-core. How do we make a distinction 
> between the 'actions' classes and come other
>  methods()/classes say under the util package about which stays and 
> which goes. Whats the reasoning ?

I'm viewing RequestUtils as a place to put common methods used by internal
Struts code.  IMO, when Struts stops using its utility methods, those
methods should go away or they will decay and be a source of bugs.  The
standard actions, however, are used by developers to build a Struts app so
it makes sense to package it with the Struts core.

David

> 
> > I think that will be highly confusing.
> >  
> >
> No more so than going from struts 1.0 -> 1.1 where the import
> statements changed for BeanUtils had to change.
> And much less confusing than pulling out the TagUtil from
> RequestUtils, which requires changing imports and code,
> instead of just the import statements.
> 
> 
> 
> >>
> >>
> >>Choose a job you love, and you will never have to work a day of your
> >>life.
> >>                                                                      
>  
> >>             -Confucius.
> >>
> >>
> >>    
> >>
> >
> >
> >__________________________________
> >Do you Yahoo!?
> >Yahoo! SiteBuilder - Free, easy-to-use web site design software
> >http://sitebuilder.yahoo.com
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
> >  
> >
> 
> 
> -- 
> -----
> Rob Leland (703-525-3580)
> 
> 
> Choose a job you love, and you will never have to work a day of your
> life.
>                                                                         
>              -Confucius.
> 
> 


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message