struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: Addition of two new actions
Date Fri, 01 Aug 2003 16:00:47 GMT


On Thu, 31 Jul 2003, Steve Raeburn wrote:

> Date: Thu, 31 Jul 2003 23:10:59 -0700
> From: Steve Raeburn <sraeburn@apache.org>
> Reply-To: Struts Developers List <struts-dev@jakarta.apache.org>,
>      sraeburn@apache.org
> To: Struts Developers List <struts-dev@jakarta.apache.org>
> Subject: Addition of two new actions
>
> I'd like to add two new actions to org.apache.struts.actions that I find
> particularly useful.
>
> 1. SuccessAction - A simple action that forwards control to an ActionFoward
> named "success".
>
> This is a very simple action, but I find it exceptionally useful,
> particularly in the early stages of development when it can act as a
> placeholder for as-yet undeveloped actions.
>
>   public ActionForward execute(
>     ActionMapping mapping,
>     ActionForm form,
>     HttpServletRequest request,
>     HttpServletResponse response)
>     throws Exception {
>
>     ActionForward forward = mapping.findForward("success");
>       if (forward == null) {
>         String message =
>           messages.getMessage("success.required", mapping.getPath());
>         log.error(message);
>         throw new ServletException(message);
>       }
>       return forward;
>     }
>

I agree with others in the thread pointing out that this would be
redundant.

> 2. ParameterDispatchAction - A DispatchAction that selects a handler method
> using the value of the ActionMapping parameter.
>
> This is as per the suggestion by Anthony Kay via Bugzilla
> <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17117>, except I prefer
> the name ParameterDispatchAction to his suggestion of ConfigDispatchAction
> as I think it's more descriptive of what the class actually does. Other than
> the name change, I've just tidied up the Javadoc and changed the
> 'unspecified' method to throw an Exception (as in DispatchAction) rather
> than return an Http error code.
>
> If no one has any problems with adding these two, I'll put them in tomorrow.

Could you help me understand how this is different from what
DispatchAction already does, or why we couldn't just update DispatchAction
itself to add any additional functionality it represents?

>
>
> Steve

Craig

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message