struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: RequestUtils.computeURL()
Date Mon, 10 Mar 2003 16:34:41 GMT


On Mon, 10 Mar 2003, James Mitchell wrote:

> Date: Mon, 10 Mar 2003 10:01:16 -0500
> From: James Mitchell <jmitchell@apache.org>
> Reply-To: Struts Developers List <struts-dev@jakarta.apache.org>
> To: Struts Developers List <struts-dev@jakarta.apache.org>
> Subject: RequestUtils.computeURL()
>
>
> Is there any reason that any tag should NOT call computeURL when
> evaluating a URL that needs a parameter of Map entries added?
>
> It seems that ImgTag does it all by itself, and since it hard-codes '&'
> instead of the standard '&amp;', my new tests (which I haven't even
> committed yet) are failing.
>
> Should we refactor this now?
>
> I cannot setup tests for this tag with the current code that's there.
>

Sounds like we missed refactoring this when computeURL() was created in
the first place, so +1 for refactoring it now.

As of last night, I got all the "test.tomcat.41" tests to run on my Linux
box (yah :-) -- thanks for all the hard work on creating these tests.  I
ran into line-end problems on the code we generate for <html:form> and
<html:errors>, so I tweaked them a bit.  I hope that didn't mess up
running the tests on Windows, and would be interested to find out if it
did.

> Thoughts?
>

Craig


>
>
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://jakarta.apache.org/struts
>
> "People demand freedom of speech to make up for the freedom of thought
> which they avoid."
>     - Soren Aabye Kierkegaard (1813-1855)
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Mime
View raw message