Mailing-List: contact struts-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Struts Developers List" <struts-dev@jakarta.apache.org>
From: "James Mitchell" <jmitchell@apache.org>
To: "'Struts Developers List'" <struts-dev@jakarta.apache.org>
Subject: RE: Test suites fail on localized computer
Date: Wed, 26 Feb 2003 11:37:31 -0500
Message-ID: <01fa01c2ddb5$5c337350$6601a8c0@atlanta>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Importance: Normal
In-Reply-To: <3E5CE691.4050301@lifl.fr>

LOL....now this is interesting, supposing I had picked a different
locale....who knows how long this might have gone undetected. =20

I just changed my regional settings to France and my tests failed as
well.  I already see the problem and will commit the fix tonight.  I
forced the locale for the MessageTag tests, but forgot to do the same
for WriteTag.


--
James Mitchell
Software Engineer/Struts Evangelist


> -----Original Message-----
> From: Cedric Dumoulin [mailto:cedric.dumoulin@lifl.fr]=20
> Sent: mercredi 26 f=E9vrier 2003 11:09
> To: Struts Developers List
> Subject: Test suites fail on localized computer
>=20
>=20
>=20
>   Hi all,
>=20
>   Today I have run the test suite test.tomcat.41, but it fail on my=20
> computer:
>=20
>     [junit] junit.framework.AssertionFailedError:=20
> expected:<1,234> but=20
> was:<1=C2 234>
>     [junit]     at=20
> org.apache.struts.taglib.bean.TestWriteTag.formatAndTest(TestW
> riteTag.java:122)
>     [junit]     at=20
> org.apache.struts.taglib.bean.TestWriteTag.endWriteTagNameForm
> at(TestWriteTag.java:153)
> =20
>   Checking the code, it appear that we compare a localized string=20
> returned by the server with a static string not localized ;-). This=20
> should work well when the server is US_en, but doesn't work=20
> with FR_fr,=20
> and other locales.
> Note that the shown returned string (<1=C2 234>) is not necessarily =
the=20
> real returned string, because the text file used to catch the output=20
> doesn't support well localization.
>=20
>   There is other comparisons of this kind in the TestWriteTag=20
> file, and=20
> maybe in other files. I have try to run ant with other locale=20
> parameters, with no success: Tomcat is always launched with=20
> the locale=20
> of my computer, which I can't change.
>   As a result, I can't run the test suites. Is there someone=20
> who have a=20
> simple solution, or should we change the TestWriteTag file (how?).
>=20
>         cedric
>=20
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org