struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Hill" <>
Subject RE: Avoid code reformating !
Date Mon, 23 Dec 2002 03:21:02 GMT
Personally I find the sun style with things just anyhow all over the place
to be quite messy & completely unreadable.

When I read source for a struts class I usually have to spend 10 minutes
moving the braces around so I can figure out what is going on...

Still one mans meat is anothers poison, and if theres one thing in
development that is bound to spark off 'holy wars' its coding style ;-)

-----Original Message-----
From: Ted Husted []
Sent: Monday, December 23, 2002 03:53
To: Struts Developers List
Subject: Re: Avoid code reformating !

It's true that since the Struts product does not define its own
code standards, we default to the Sun conventions, as given by the
Jakarta guidelines.

Personally, I augment these with the Java Elements of Style,
which, in practice, act like a superset of the Sun conventions.

As a practical matter, we do have to balance "Observe the style of
the original" with our responsibility to maintain a code base for
the benefit of others (rather than ourselves).

Technically, we should veto submissions that do not follow the Sun
coding conventions, but we've been lax about that in the past.

I would simply suggest that we continue to follow the practice of
submitting code changes and style changes separately. If someoone
has a stylistic scratch to itch, they should scratch it. (But it
would be polite to find a bug itch to scratch first =:)

Incidentally, the tab thing is because we email the deltas and
sending tabs by email is problematic =:(


12/16/2002 6:44:07 PM, David Graham <>

>A couple of things:
>1.  Tabs were addressed as an issue but the jakarta guidelines
state that
>tabs are not to be used in the first place.  This drives me crazy
but I
>follow it nonetheless.
>2.  I agree with closing one line blocks but this isn't in any
>I've seen a lot of Struts code that will follow an unclosed one
line block
>with more code which makes it very confusing.  This is fair game
>changing in my book.
>3.  I disagree that we should stop formatting code.  We have a
standard that
>we should be following.  If we need to change that standard then
we can
>debate that.
>>From: Erik Hatcher <>
>>Reply-To: "Struts Developers List" <struts->
>>To: Struts Developers List <>
>>Subject: Re: Avoid code reformating !
>>Date: Mon, 16 Dec 2002 18:25:55 -0500
>>As for seeing a class structure, this is what IDE's like Eclipse
and IDEA
>>make a moot point.  I think if code doesn't follow the Jakarta
>>project-specific) conventions then its fair game for
reformatting.  This is
>>communal code and no one person owns it, this is why conventions
exist and
>>we must adhere to them for the sake of the "community".  Please.
>>But, while we are talking about coding conventions, at least
please adopt
>>closing if/for/while/etc blocks with curly brackets for one-line
>>The Struts codebase is littered with non-curly-bracketed one-
line blocks
>>and that in and of itself drives me nuts when I'm trying to
follow the
>>code.  :))
>>	Erik
>>Cedric Dumoulin wrote:
>>>  I said that I don't want to debate on this. I know the
reformated code
>>>doesn't follow the recomanded Jakarta rules code standard. But
>>>rule is to respect any other well formated standard ;-).
>>>  For me, the reformated code is really unreadable: I can't
detect the
>>>classes and methods structures at a glance, and so it requires
me some
>>>times to try to figure it out. I thing it is a waste of time
>>>     Cedric
>>To unsubscribe, e-mail:
>>For additional commands, e-mail:
>Protect your PC - get VirusScan Online
>To unsubscribe, e-mail:   <mailto:struts-dev->
>For additional commands, e-mail: <mailto:struts-dev->

To unsubscribe, e-mail:   <>
For additional commands, e-mail: <>

To unsubscribe, e-mail:   <>
For additional commands, e-mail: <>

View raw message